fix(gateway): reject expired certificate reloads - #931
Merged
Conversation
kvinwang
force-pushed
the
codex/fix-gateway-expired-cert-reload
branch
from
August 4, 2026 15:25
54efaa2 to
c269d2a
Compare
kvinwang
force-pushed
the
codex/fix-gateway-expired-cert-reload
branch
from
August 5, 2026 01:55
c269d2a to
f938659
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Gateway certificate reloads accepted expired replacement certificates. Installing one could replace a working in-memory identity and immediately break TLS handshakes.
A naive validity check in the store builder also caused an expired certificate for one domain to block an unrelated domain from being renewed, because incremental updates rebuilt and revalidated the entire store.
Fix
The branch is rebuilt on current
master; the certificate/key pairing validation from #917 remains provided bymaster.Verification
cargo fmt --manifest-path dstack/Cargo.toml --allcargo check --manifest-path dstack/Cargo.toml -p dstack-gatewaycargo test --manifest-path dstack/Cargo.toml -p dstack-gateway cert_store::tests -- --nocapturegit diff --check