Skip to content

[STACKED on #932] fix(gateway): accept app-info peer identities - #936

Merged
kvinwang merged 2 commits into
masterfrom
codex/fix-gateway-app-info-peer-identity
Aug 5, 2026
Merged

[STACKED on #932] fix(gateway): accept app-info peer identities#936
kvinwang merged 2 commits into
masterfrom
codex/fix-gateway-app-info-peer-identity

Conversation

@kvinwang

@kvinwang kvinwang commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator

STACKED PR — merge #932 first.

Problem

Peer synchronization required a legacy identity form and rejected valid peers that identify themselves using app-info records. Healthy peers therefore failed authentication during mixed-version synchronization.

Root cause and fix

Accept and verify the supported app-info peer identity representation while retaining the existing trust checks.

Implementation

The branch records the following focused implementation work:

  • fix(gateway): accept app-info peer identities
  • fix(gateway): decode app-info peer identity

Changed paths:

  • dstack/gateway/src/web_routes/wavekv_sync.rs

Scope

This PR addresses one logical gateway finding. It intentionally excludes the acceptance-test infrastructure from #841 and unrelated product fixes from #840.

Dependency and merge order

Verification

  • git diff --check origin/codex/fix-gateway-peer-sync-urls..origin/codex/fix-gateway-app-info-peer-identity: passed.
  • The declared base was verified as an ancestor of the PR head.
  • Focused compile/check verification was run for the changed component where applicable; non-Rust packaging or configuration changes were reviewed against their exact branch delta.

Copilot AI review requested due to automatic review settings July 31, 2026 03:13

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Base automatically changed from codex/fix-gateway-peer-sync-urls to master August 5, 2026 01:49
@kvinwang
kvinwang force-pushed the codex/fix-gateway-app-info-peer-identity branch from 34e6494 to 2365af0 Compare August 5, 2026 01:49
@kvinwang
kvinwang force-pushed the codex/fix-gateway-app-info-peer-identity branch from 2365af0 to ddacec1 Compare August 5, 2026 02:16
@kvinwang
kvinwang merged commit 33fec94 into master Aug 5, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants