Skip to content

[STACKED on #1016] fix(guest): make gateway refresh failover atomic - #962

Merged
kvinwang merged 5 commits into
fix/guest-local-provider-inventory-masterfrom
codex/fix-guest-gateway-refresh-failover
Aug 6, 2026
Merged

[STACKED on #1016] fix(guest): make gateway refresh failover atomic#962
kvinwang merged 5 commits into
fix/guest-local-provider-inventory-masterfrom
codex/fix-guest-gateway-refresh-failover

Conversation

@kvinwang

@kvinwang kvinwang commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator

STACKED PR — merge #1016 first.

Problem

Gateway refresh failover updated endpoint/state pieces incrementally. If the first endpoint failed and the next succeeded, readers could observe a mixed old/new gateway state during the transition.

Root cause and fix

Build the successful refresh result off to the side and atomically replace gateway state only after one endpoint completes.

Implementation

The branch records the following focused implementation work:

  • fix(guest): make gateway refresh failover atomic
  • style(guest): format gateway refresh tests
  • fix(guest): retain gateway keys across failover attempts
  • style(guest): format gateway failover closure

Changed paths:

  • dstack/dstack-util/src/system_setup.rs

Scope

This PR addresses one logical guest finding. It intentionally excludes the acceptance-test infrastructure from #841 and unrelated product fixes from #840.

Dependency and merge order

Verification

  • git diff --check origin/codex/fix-guest-local-provider-inventory..origin/codex/fix-guest-gateway-refresh-failover: passed.
  • The declared base was verified as an ancestor of the PR head.
  • Focused compile/check verification was run for the changed component where applicable; non-Rust packaging or configuration changes were reviewed against their exact branch delta.

Copilot AI review requested due to automatic review settings July 31, 2026 03:26

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@kvinwang
kvinwang force-pushed the codex/fix-guest-local-provider-inventory branch 2 times, most recently from ac918d6 to cbb6665 Compare August 5, 2026 09:22
Base automatically changed from codex/fix-guest-local-provider-inventory to codex/fix-guest-kms-failover-order August 5, 2026 10:24
@kvinwang
kvinwang force-pushed the codex/fix-guest-gateway-refresh-failover branch 2 times, most recently from 48f99b3 to 9716c70 Compare August 6, 2026 02:48
@kvinwang kvinwang changed the title [STACKED on #954] fix(guest): make gateway refresh failover atomic [STACKED on #1016] fix(guest): make gateway refresh failover atomic Aug 6, 2026
@kvinwang
kvinwang changed the base branch from codex/fix-guest-kms-failover-order to fix/guest-local-provider-inventory-master August 6, 2026 02:48
@kvinwang
kvinwang force-pushed the fix/guest-local-provider-inventory-master branch from 3ca0e7e to 845af54 Compare August 6, 2026 02:52
@kvinwang
kvinwang force-pushed the codex/fix-guest-gateway-refresh-failover branch from 9716c70 to e4a3156 Compare August 6, 2026 02:52
@kvinwang
kvinwang merged commit e1745d6 into fix/guest-local-provider-inventory-master Aug 6, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants