fix: use server.ws.clientPort on Vite 8.1+ - #620
Merged
ElMassimo merged 1 commit intoAug 27, 2026
Conversation
Vite 8.1 deprecated server.hmr.* in favor of server.ws.*. Keep server.hmr.clientPort on Vite 8.0 so HMR still bypasses rack-proxy. Closes ElMassimo#614.
Owner
|
Looks great, thanks! |
davidrunger
added a commit
to davidrunger/david_runger
that referenced
this pull request
Aug 27, 2026
Version 5.2.3 adds native Vite 8 WebSocket configuration support through ElMassimo/vite_ruby#620, allowing `vite.config.mjs` to call `RubyPlugin()` directly and remove the `RubyPluginWithWebSocketConfig` transformation. Set `skipProxy` to load development entrypoints directly from Vite. The Vite client can then derive its WebSocket address from its own script URL, making the explicit `server.ws.clientPort` workaround and its config regression spec unnecessary. Permit only the local Vite HTTP and WebSocket paths in the domain-restricted Cuprite driver so feature specs can use the live server. Delay `vite-plugin-full-reload` notifications by 100 ms so the Rails evented view reloader can invalidate changed server-rendered templates before the browser requests them. This uses the Rails-specific `delay` option documented at https://github.com/ElMassimo/vite-plugin-full-reload#configuration-%EF%B8%8F and prevents the first automatic reload from rendering stale compiled Haml. Keep the existing Ruby dependencies unchanged. `vite_ruby` 3.10.2 already supports `vite-plugin-ruby` 5.2.x, while updating it would also pull in `rack-proxy` 1.0 and break the Rails development proxy because of that dependency major version change in backend policy. Refresh and deduplicate the `pnpm` lockfile. The initial `pnpm dedupe` was blocked by the minimum-release-age policy, so temporarily exempt `picomatch@4.0.7` and `vite-plugin-ruby@5.2.3` through the workspace configuration; `pnpm-update-js-packages` refreshes those exemptions on later updates. codex resume 01a04431-06e8-7763-89bc-f735429ac1f7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📖
vite-plugin-ruby still writes
server.hmr.clientPort, which Vite 8.1 logs as deprecated on everybin/vite dev.Closes #614.
Background 📜
rack-proxy does not forward websockets, so the plugin sets
clientPortto the Vite port. Vite 8.1 moved that option toserver.ws.*; Vite 8.0 still readsserver.hmr.clientPort.The Fix 🔨
Write
server.ws.clientPortfrom Vite 8.1 onward, and keep the old assignment for Vite 5–8.0.Screenshots 📷