fix: support rack-proxy 1.0 (close #622) - #623
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📖
This pull request makes
ViteRuby::DevServerProxycompatible with rack-proxy 1.0, so proxied asset requests during development no longer fail with502 Bad Gateway. Closes #622.Background 📜
This was happening because #619 relaxed the dependency to
rack-proxy >= 0.6.1, which lets bundler resolve rack-proxy 1.0. rack-proxy 1.0 refuses to derive a backend from the client-controlledHostheader unless you explicitly opt in (an SSRF/open-proxy guard).DevServerProxyselected the Vite backend precisely by rewriting theHostheader, so on rack-proxy 1.0 every proxied request returned[502, {}, []]:The Fix 🔨
By changing
forward_to_vite_dev_serverto set an explicit, config-derived backend on the request env rather than relying on theHostheader: