Conversation
Impl detail for recording the positions of all elements in advance.
- include more pixel data fragments
- tweak docs
- [object] rename accordingly at lazy::record
Ongoing implementation of lazy DICOM data elements
- also add crate visible `InMemoryDicomObject::from_parts`
- [core] tweak documentation of `P` type parameter in `Value<I, P>`
- Add more core, remove commented out code
- update snafu usage - drop type parameter `D` where it was dropped - replace use of `to_clean_str` - fix other things - clean up imports
Enet4
force-pushed
the
imp/object/lazy
branch
from
September 23, 2022 09:53
04bf39a to
751f258
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request aims to provide a baseline for #1.
It already contains some changes to the parser create and other mid level constructs for recording data set value positions in the file. Although it does not cover a uniform way to manipulate with DICOM objects of any implementation, it will hopefully be open for experimentation in the next release.
What should be done to complete this PR is to create the main lazy object building routine and finish writing the API.