Revise dicom-app-common library - #794
Conversation
- add support for PeerCert::Ignore in client_config,
using a server certificate verifier that skips verification
with a warning
- Rename `TLSProtocolVersion` to `TlsProtocolVersion`
- and rename variants to match `ProtocolVersion` from rustls
- fix system roots flag option,
which had `ArgAction::SetFalse` when it should have been enabled
- rename a few error variants and split others
- remove anti-pattern of Io and Rustls error wrappers,
replace with informative variants
- make error type non-exhaustive
- enabled use of value delimiter in suitable args
- add and adjust documentation
- feature gate new constructs and error variants depending on rustls
- add dicom_app_common=debug in verbose mode
7539585 to
04129c0
Compare
|
Can be findscu/src/query.rs and movescu/src/query.rs unified in app-common? This file is duplicated in this two places |
I don't think these belong in After that, I think a few of us have been in conversations around adding a higher level module for dimse (see #781), issue discussion here |
- remove typo from `PeerCertOption` docs - replace `use_value_delimiter` with `value_delimiter` in TlsOptions arguments - move warning on ignore peer cert in client_config
|
Thank you for the feedback! Regarding the |
Just a few clean-ups and bug fixes here and there.
Bring support for
PeerCert::Ignorewhen setting up a TLS client, via a server certificate verifier that skips verification.Rename
TLSProtocolVersiontoTlsProtocolVersionFix system roots flag option, which had
ArgAction::SetFalsewhen it should have been enabled on--system-rootsRename a few error type variants and split others
make error type non-exhaustive
enabled use of value delimiter in suitable args, so that comma-separated values would actually work
Adjust documentation
[storescp] [storescu] adjust log filters: add
dicom_app_common=debugin verbose mode