Conversation
Enet4
self-requested a review
September 10, 2026 08:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #829.
jpeg-encoderasColorType::Rgb, which converts the samples to YCbCr and writes a JFIF stream. The attribute changes returned byencode_framenevertheless asked for (0028,0004) Photometric Interpretation to beRGB. RequestYBR_FULL_422instead, since that is the color space of the encoded data.RGBis not an invalid value here — Table 8.2.1-1 in PS3.5 Section 8.2.1 lists bothYBR_FULL_422andRGBfor the 3-sample row of JPEG Baseline. What the same section does require is that the Data Elements describing the Pixel Data encoding be consistent with the characteristics of the compressed data stream, and aRGBtag over a YCbCr codestream is not.