Fix insufficient spacing between card name and issue card button on resize by MobileMage · Pull Request #97018 · Expensify/App

MobileMage · 2026-07-25T01:21:14Z

Explanation of Change

On the Expensify Card list page, the gap between the feed selector (Card name) and the header buttons collapses when you resize the window to a medium width. At medium width the buttons stack onto a separate line (shouldChangeLayout), but the margin that created the gap (styles.mt3) sits behind shouldDisplayButtonsInSeparateLine, which only turns true in the narrow-portrait layout. So at medium width no spacing applies and the Card name and buttons touch.

This PR puts a permanent flex gap on the shared parent that wraps the FeedSelector and the header buttons. One styles.gap3 (12px, the same value as the old mt3) holds the separation in both layouts: horizontal when the row is side-by-side, vertical when it stacks. The stale mt3 line is removed.

Fixed Issues

$ #94988
PROPOSAL: #94988 (comment)

Tests

Navigate to Workspace > Expensify Card.
Resize the browser window to a narrower width.
Verify adequate spacing is maintained between the Card name label and the Issue card button at all supported window sizes.

Verify that no errors appear in the JS console

Offline tests

No offline-specific behavior. The change is layout only.

Verify that no errors appear in the JS console

QA Steps

Same as Tests.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Videos will be added in a few hours.

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Apply a permanent flex gap3 on the feed-selector/header-buttons parent container instead of the conditional mt3 margin, which never applied at medium width because shouldDisplayButtonsInSeparateLine is false there. Fixes Expensify#94988.

codecov · 2026-07-25T01:25:49Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...e/expensifyCard/WorkspaceExpensifyCardListPage.tsx	`0.00% <0.00%> (ø)`
... and 40 files with indirect coverage changes

melvin-bot · 2026-07-29T22:26:10Z

@rojiphil Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

joekaufmanexpensify

Good for product.

rojiphil · 2026-08-01T06:33:25Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

97018-android-hybrid-001.mp4

Android: mWeb Chrome

97018-mweb-chrome-001.mp4

iOS: HybridApp

97018-ios-hybrid-001.mp4

iOS: mWeb Safari

97018-mweb-safari-001.mp4

MacOS: Chrome / Safari

97018-web-chrome-001.mp4

rojiphil

Thanks @MobileMage for the PR.

@arosiclair Changes LGTM and works well.
Over to you for review. Thanks

github-actions · 2026-08-03T12:39:35Z

🚧 arosiclair has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-08-03T12:44:29Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-08-03T12:46:00Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #97018.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-c804f00ca6e-3d7ad2f-723b4c28af01cbc26042e3d2a1d4ff83095dd29b/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-c804f00-3d7ad2f-1cce3aa4b95feadf96d8c8367c1d17d573cd2a59/index.html

Web 🕸️
https://97018.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-08-03T23:51:25Z

🚀 Deployed to staging by https://github.com/arosiclair in version: 9.4.49-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-08-04T00:00:08Z

🤖 No help site changes required.

This PR is a layout-only spacing fix on the Expensify Card list page. It changes CSS style arrays (adds a flex styles.gap3 on the shared parent wrapping the FeedSelector and header buttons, and removes the stale styles.mt3) in a single file, WorkspaceExpensifyCardListPage.tsx.

Why no docs update is needed

The diff touches only style arrays — no user-facing copy, button labels, feature names, tab names, or settings labels were added or changed.
There is no behavioral change: cards, feeds, buttons, and workflows all function exactly as before; only the spacing between the Card name selector and header buttons is corrected on resize.
The help site articles under docs/articles/new-expensify/expensify-card/ document Expensify Card setup, settings, spend rules, reconciliation, and troubleshooting — none of which describe the pixel-level layout of the card list page. Nothing in those articles is now inaccurate as a result of this change.

Since no documented feature or behavior changed, I did not create a draft help site PR.

@MobileMage, please confirm you agree no help site update is needed here. If you believe a docs change is warranted, let me know what behavior should be documented and I'll draft a PR.

OSBotify · 2026-08-04T21:44:43Z

🚀 Deployed to production by https://github.com/arosiclair in version: 9.4.49-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android

melvin-bot Bot assigned MobileMage Jul 25, 2026

MobileMage mentioned this pull request Jul 25, 2026

[Due for payment 2026-08-11] [$250] Insufficient spacing between Card name and Issue card button when window is resized #94988

Closed

7 tasks

MobileMage marked this pull request as ready for review July 29, 2026 22:26

MobileMage requested review from a team as code owners July 29, 2026 22:26

melvin-bot Bot requested review from rojiphil and removed request for a team July 29, 2026 22:26

melvin-bot Bot requested review from joekaufmanexpensify and removed request for a team July 29, 2026 22:26

joekaufmanexpensify approved these changes Jul 30, 2026

View reviewed changes

rojiphil approved these changes Aug 1, 2026

View reviewed changes

melvin-bot Bot requested a review from arosiclair August 1, 2026 06:34

arosiclair approved these changes Aug 3, 2026

View reviewed changes

arosiclair merged commit c804f00 into Expensify:main Aug 3, 2026
41 of 44 checks passed

OSBotify mentioned this pull request Aug 3, 2026

Deploy Checklist: New Expensify 2026-08-03 #97732

Closed

77 tasks

Navigation Menu

Fix insufficient spacing between card name and issue card button on resize - #97018

Fix insufficient spacing between card name and issue card button on resize#97018
arosiclair merged 1 commit into
Expensify:mainfrom
MobileMage:MobileMage/fix-94988-card-spacing

MobileMage commented Jul 25, 2026 •

edited

Loading

Uh oh!

codecov Bot commented Jul 25, 2026 •

edited by github-actions Bot

Loading

Uh oh!

melvin-bot Bot commented Jul 29, 2026

Uh oh!

joekaufmanexpensify left a comment

Uh oh!

rojiphil commented Aug 1, 2026

Uh oh!

rojiphil left a comment

Uh oh!

Uh oh!

github-actions Bot commented Aug 3, 2026

Uh oh!

OSBotify commented Aug 3, 2026

Uh oh!

github-actions Bot commented Aug 3, 2026

Uh oh!

OSBotify commented Aug 3, 2026

Uh oh!

MelvinBot commented Aug 4, 2026

Uh oh!

OSBotify commented Aug 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

MobileMage commented Jul 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Jul 25, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Jul 29, 2026

Uh oh!

joekaufmanexpensify left a comment

Choose a reason for hiding this comment

Uh oh!

rojiphil commented Aug 1, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

rojiphil left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Aug 3, 2026

Uh oh!

OSBotify commented Aug 3, 2026

Uh oh!

github-actions Bot commented Aug 3, 2026

Uh oh!

OSBotify commented Aug 3, 2026

Uh oh!

MelvinBot commented Aug 4, 2026

Uh oh!

OSBotify commented Aug 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

MobileMage commented Jul 25, 2026 •

edited

Loading

codecov Bot commented Jul 25, 2026 •

edited by github-actions Bot

Loading