Skip to content

Hold the xunit-dotnet monorepo on 3.x until the test host is migrated - #112

Merged
wormeyman merged 1 commit into
mainfrom
chore/hold-xunit-v4
Sep 11, 2026
Merged

wormeyman merged 1 commit into
mainfrom
chore/hold-xunit-v4

Conversation

@wormeyman

@wormeyman wormeyman commented Sep 11, 2026

Copy link
Copy Markdown
Collaborator

Records the refusal of #108 as a Renovate hold, so the bot stops re-proposing it every Monday.

What failed

xunit.v3 4.0.0 and xunit.runner.visualstudio 4.0.0 failed both .NET test jobs, identically on CI and on a local Mac:

Microsoft.Testing.Platform.MSBuild.targets(320,5): error : Testing with VSTest
target is no longer supported by Microsoft.Testing.Platform on .NET 10 SDK and
later. If you use dotnet test, you should opt-in to the new dotnet test experience.

xunit.v3 4.0.0 depends on xunit.v3.mtp-v2 [4.0.0, 4.0.0], which pulls Microsoft.Testing.Platform 2.x. MTP 2 drops the VSTest bridge on the .NET 10 SDK, so the current dotnet test invocation has nowhere to run.

That makes this a test-host migration rather than a version bump. The work is tracked in #111: opt the project into the new dotnet test, and replace the VSTest-only --logger "console;verbosity=normal" that both .NET jobs in ci.yml pass.

The rule

Ceiling is <4.0.0, not enabled: false, matching every other hold in the file - patches inside 3.x keep flowing and only the major is blocked. The rule carries its reason and points at #111, so the refusal travels attached to the next proposal instead of being re-derived.

Also updated: the header's hold count (six to seven) and the tracking-issue list in the packageRules comment block.

Verification

Ran the validator the file's own comment calls for, given that an unparseable config makes Renovate do nothing silently:

npx --yes --package renovate -- renovate-config-validator .github/renovate.json5
 INFO: Validating .github/renovate.json5 as global config
 INFO: Config validated successfully against 1 file(s)

Not affected

Verify.XunitV3 32.0.0 is a separate package and merged cleanly in #106 - both .NET test jobs passed on it. The Verify grouping rule above this one is untouched.

🤖 Generated with Claude Code

https://claude.ai/code/session_01DAVZSEbjCkr9sbumdMPKy2

Summary by CodeRabbit

  • Chores
    • Updated dependency maintenance rules for testing tools, allowing compatible 3.x patch updates while holding major-version upgrades.
    • Documented the current migration requirements and tracking information for the future test workflow transition.

Renovate proposed xunit.v3 4.0.0 and xunit.runner.visualstudio 4.0.0 in
#108. Both .NET test jobs failed, identically on CI and on a local Mac:

  Microsoft.Testing.Platform.MSBuild.targets(320,5): error : Testing with
  VSTest target is no longer supported by Microsoft.Testing.Platform on
  .NET 10 SDK and later. If you use dotnet test, you should opt-in to the
  new dotnet test experience.

xunit.v3 4.0.0 depends on xunit.v3.mtp-v2 [4.0.0, 4.0.0], which pulls
Microsoft.Testing.Platform 2.x, and MTP 2 drops the VSTest bridge on the
.NET 10 SDK. So this is a test-host migration, not a version bump: the test
project has to opt into the new `dotnet test`, and ci.yml's two .NET jobs
both pass `--logger "console;verbosity=normal"`, which is VSTest syntax MTP
does not accept. #111 has the full checklist.

The ceiling is <4.0.0 rather than `enabled: false`, matching every other
hold in this file - patches inside 3.x keep flowing and only the major is
blocked. Without it the bot re-proposes v4 every Monday, which is the exact
re-litigation the header of this file says the holds exist to prevent.

This is the seventh hold, so the count in the header moves with it, and the
tracking-issue list gains the migration-shaped entry.

Verified with the validator the file's own comment calls for:

  npx --yes --package renovate -- renovate-config-validator .github/renovate.json5
  INFO: Config validated successfully against 1 file(s)

Verify.XunitV3 32.0.0 is unaffected and merged separately in #106 - both
.NET test jobs passed on it.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DAVZSEbjCkr9sbumdMPKy2
@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: b9ed1efa-e2c1-441f-9c4e-9429805db039

📥 Commits

Reviewing files that changed from the base of the PR and between 3ae57b9 and b9526fe.

📒 Files selected for processing (1)
  • .github/renovate.json5

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The Renovate configuration now documents seven deliberate holds, tracks the xunit-dotnet migration in issue 111, and prevents xunit.v3 and its Visual Studio runner from upgrading to version 4.

Changes

xunit Renovate hold

Layer / File(s) Summary
Configure the xunit version hold
.github/renovate.json5
The configuration updates the hold count, adds issue 111 to the xunit-dotnet migration tracking list, and holds xunit.v3 and xunit.runner.visualstudio below version 4 while allowing 3.x patches.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to b9526

The Renovate hold safely prevents the incompatible xUnit v4 upgrade while allowing supported 3.x maintenance updates.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: holding the xunit-dotnet monorepo on version 3.x until the test host migration is complete.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/hold-xunit-v4

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@wormeyman
wormeyman merged commit 05bdb69 into main Sep 11, 2026
5 checks passed
@wormeyman
wormeyman deleted the chore/hold-xunit-v4 branch September 11, 2026 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant