[luv-cut-1.0.0-beta.2] Cut 1.0.0-beta.2 - #636
Open
NiveditJain wants to merge 1 commit into
Open
Conversation
Version only, on a `luv-cut-*` branch, with Cargo.toml and Cargo.lock moving together — the release build runs `cargo build --locked`, which hard-errors when the lockfile records a different workspace version. Ships the config-flow fix (sudo prompted in-process at step 0, and the wizard refusing to run under sudo at all) plus three review findings in the system-service install: a symlink-able staging path for the privileged write, an unquoted FAILPROOFAI_WORKER_CMD that broke on any path with a space, and a launchd label that was not per-user. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EbXKFnpRXBwsrvUJDdySky
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release cut for 1.0.0-beta.2 — version only (
package.json,Cargo.toml,Cargo.lock).Based on
failproofaid(#632) rather thanmain, so the diff is just the version lines; the work itself is reviewed there.Cargo.lockmoves with the other two because the release build runscargo build --locked, which hard-errors when the lockfile records a different workspace version thanCargo.toml.What this release ships
sudo failproofai configis gone as advice — and the wizard now refuses to run under sudo whenSUDO_USERshows a real user behind it. Under sudo,homedir()is/root: hooks land in root's settings,daemonConfiguredis set for root, the binary downloads to/root/.failproofai/bin, and the unit carriesUser=root.sudo -vprompts on a clean terminal and caches the credential, so the install itself stays non-interactive instead of firing an invisible prompt under a drawn TUI frame.writeFileSyncwould follow a symlink through (local root-write vector), an unquotedFAILPROOFAI_WORKER_CMDthat broke on any path with a space (the daemon runs it throughsh -c), and a launchd label that was not per-user, so a second Mac user's install overwrote the first's daemon.Verified
Published through
publish.yml— dry run, then live:next: 1.0.0-beta.2;beta(0.0.15-beta.1) andlatest(0.0.15) untouchedv1.0.0-beta.2with four.gzbinaries +SHA256SUMSmain's version untouched🤖 Generated with Claude Code
https://claude.ai/code/session_01EbXKFnpRXBwsrvUJDdySky