fix(website): the hero shows a download button and a link, nothing else - #144
Merged
Conversation
The release note under the download had grown into a paragraph: version, platform, the Gatekeeper explanation, and an instruction to verify the SHA-256 — all of it repeating what the button already says or what belongs on the release page. The unavailable states were no better, explaining which platform comes first. A landing page hero is not the place for it. Both notes are now just "release history". Removing the only reader of `#portal-release-status` made three things dead: that element, `portalManifestReason`, and `portalManifestStatus`. They are gone rather than left assigned and never read. `build.note` goes with them. This also removes the element whose absence used to freeze the download button, since `updatePortalDownload` no longer looks it up at all.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The note under the download had grown into a paragraph — version, platform, the Gatekeeper explanation, and an instruction to verify the SHA-256, all repeating the button or belonging on the release page. The unavailable states explained which platform ships first. Both are now just
release history.Removing the only reader of
#portal-release-statusmade three things dead: that element,portalManifestReason, andportalManifestStatus. Deleted rather than left assigned-but-never-read.build.notegoes with them.Side benefit:
updatePortalDownloadno longer looks up that element, so its absence can't freeze the download button the way it did before.website_static_gate=ok,node --checkclean, 30/30 shell tests.