feat: store song filename in saved JSON - #201
Merged
Merged
Conversation
Instead of storing the whole path for songs in the manifest, only store the filename, since we know the base path from NongManager. Makes it easier to port Jukebox data across systems.
Fleeym
force-pushed
the
fix/filename-store
branch
from
September 6, 2026 20:47
24e466a to
494c82d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of storing the whole path for songs in the manifest, only store the filename, since we know the base path from NongManager.
Makes it easier to port Jukebox data across systems.