feat(web-ui): refine conversation annotation experience - #3089
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improve the conversation annotation experience across transcript selections and composer attachments.
Type and Areas
Type:
UI/UX, feature, test, docs
Areas:
Web UI, Flow Chat, Appearance/theme
Motivation / Impact
Annotations previously lost their visible selection state and appeared as separate composer attachments. Marker placement could also become detached from the selected text or disappear in dense content.
Annotated text now remains visibly selected, numbered markers stay attached to the selection corner, and composer annotations are presented as a compact grouped capsule with accessible detail controls.
Legacy Appearance packages receive the annotation accent token without replacing their configured global accent.
Verification
pnpm --dir src/web-ui exec vitest run src/flow_chat/components/ChatInputAttachments.test.tsx src/flow_chat/selection/FlowChatSelectionBar.test.tsx src/flow_chat/selection/ConversationExcerptMarkers.test.tsx src/flow_chat/selection/conversationExcerptMarkerPosition.test.ts src/infrastructure/appearance/builtins/composeAppearancePackage.test.ts --maxWorkers=50%pnpm run check:webgit diff --checkManual UI interaction verification remains pending per the Flow Chat verification guide. Remote workspace, remote control, Peer Device Mode, and Detached Dispatch scenarios were not exercised; this change is limited to shared Web UI presentation and interaction state.
Reviewer Notes
The annotation accent is owned by
--openbitfun-component-conversation-excerpt-accentand resolves to#059cb0across built-in themes. Selection backgrounds use 30% opacity, while source number markers use a solid accent fill with inverse text.Persistent highlights are owned per mounted transcript row so sibling panes do not clear each other during cleanup.
Checklist