chore: fix HasMutation display - #1505
Conversation
|
This is a preview of the changelog of the next release. If this branch is not up-to-date with the current main branch, the changelog may not be accurate. Rebase your branch on the main branch to get the most accurate changelog. Note that this might contain changes that are on main, but not yet released. Changelog: 0.14.0 (2026-08-26)⚠ BREAKING CHANGES
Features
|
There was a problem hiding this comment.
Pull request overview
Fixes user-facing mutation filter display by converting the internal 0-based mutation position index to the 1-based index users expect, aligning HasMutation with other mutation-related filters. Also updates the npm lockfile package name to match the repository’s package name.
Changes:
- Update
HasMutation::toString()to renderposition_idxas 1-based (position_idx + 1). - Rename the lockfile package name from
silotorhydbinpackage-lock.json.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/rhydb/query_engine/scalar_expressions/has_mutation.cpp | Adjusts HasMutation string rendering to display 1-based mutation positions for users. |
| package-lock.json | Updates lockfile package name to rhydb to match package.json. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Summary
In mutation filters, the mutation index starts at 1 for users, but RhyDB internally uses a 0-based index -> in that display, we need to convert. The other mutation filters already do that.
(and drive-by fix: update the package.lock to include the new package name)