Skip to content

chore: fix HasMutation display - #1505

Merged
fengelniederhammer merged 1 commit into
mainfrom
fixMutationDisplay
Aug 27, 2026
Merged

chore: fix HasMutation display#1505
fengelniederhammer merged 1 commit into
mainfrom
fixMutationDisplay

Conversation

@fengelniederhammer

@fengelniederhammer fengelniederhammer commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Summary

In mutation filters, the mutation index starts at 1 for users, but RhyDB internally uses a 0-based index -> in that display, we need to convert. The other mutation filters already do that.

(and drive-by fix: update the package.lock to include the new package name)

@fengelniederhammer
fengelniederhammer requested review from taepper and a lite review from Copilot August 26, 2026 07:58
@fengelniederhammer fengelniederhammer self-assigned this Aug 26, 2026
@github-actions

Copy link
Copy Markdown
Contributor

This is a preview of the changelog of the next release. If this branch is not up-to-date with the current main branch, the changelog may not be accurate. Rebase your branch on the main branch to get the most accurate changelog.

Note that this might contain changes that are on main, but not yet released.

Changelog:

0.14.0 (2026-08-26)

⚠ BREAKING CHANGES

  • query_engine: column = null and column <> null filters are no longer supported and now return a query error. Use column.isNull() / column.isNotNull() instead.

Features

  • query_engine: add comparison operators (<,>,<=,>=) to SaneQL (#1495) (5351116)
  • query_engine: disallow column = null filters (#1504) (77b23a5)
  • rhydb: return ISO week date string from isoWeek() (81e17a3)
  • roaring_util: add container-level set-algebra operators (#1491) (70a1bdd)
  • storage: implement int64 column (#1448) (509820b)

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes user-facing mutation filter display by converting the internal 0-based mutation position index to the 1-based index users expect, aligning HasMutation with other mutation-related filters. Also updates the npm lockfile package name to match the repository’s package name.

Changes:

  • Update HasMutation::toString() to render position_idx as 1-based (position_idx + 1).
  • Rename the lockfile package name from silo to rhydb in package-lock.json.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/rhydb/query_engine/scalar_expressions/has_mutation.cpp Adjusts HasMutation string rendering to display 1-based mutation positions for users.
package-lock.json Updates lockfile package name to rhydb to match package.json.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/rhydb/query_engine/scalar_expressions/has_mutation.cpp
@fengelniederhammer
fengelniederhammer merged commit edda8d3 into main Aug 27, 2026
25 checks passed
@fengelniederhammer
fengelniederhammer deleted the fixMutationDisplay branch August 27, 2026 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants