Conversation
Align predict_on_seqs with predict_on_dataset / ISM_predict by routing through make_predict_loader and Lightning Trainer.predict instead of eagerly moving the full one-hot batch onto the device. Keeps the device= keyword for backward compatibility with existing tutorials. Fixes Genentech#154
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
predict_on_seqseagerly moved the full one-hot batch onto the device and ran a single forward pass, which OOMs on large models (e.g. Borzoi in1_inference.ipynbon 16GB VRAM).predict_on_seqswithpredict_on_dataset/ISM_predictby usingmake_predict_loader+ LightningTrainer.predictso inference is batched.devices,num_workers,batch_size, andprecisionkwargs (defaults:batch_size=1for memory safety on large models).device=keyword as a backward-compatible alias so existing tutorials (predict_on_seqs(..., device=0)) continue to work.Test plan
pytest tests/test_lightning.py::test_lightning_model_predict_on_seqs(CPU; covers single/multi seqs,devices=,device=alias, andbatch_size)pytest tests/test_lightning.py::test_lightning_model_predict_on_datasetstill passespredict_on_seqsfromdocs/tutorials/1_inference.ipynbon a 16GB GPU