WIP: CI: Fix the Visual Studio path due to the upgrading of Windows runner image - #4860
Closed
seisman wants to merge 1 commit into
Closed
WIP: CI: Fix the Visual Studio path due to the upgrading of Windows runner image#4860seisman wants to merge 1 commit into
seisman wants to merge 1 commit into
Conversation
seisman
added
maintenance
seisman
added
run/test-gmt-dev
seisman
marked this pull request as draft
August 25, 2026 07:09
seisman
changed the title
Member
Author
|
Superseded by #4861. |
seisman
added a commit
that referenced
this pull request
Aug 25, 2026
The Windows runner image upgrade moved Visual Studio from "...\2022\Enterprise\..." to "...\18\Enterprise\...", breaking the hardcoded vcvars64.bat path (see PR #4860). Use the TheMrMilchmann/setup-msvc-dev action instead, which locates the VS installation dynamically via vswhere and exports the environment to later steps, so future runner image upgrades don't require another hardcoded-path fix. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
windows-latest/windows-2025runner image upgraded its Visual Studio to 2026 in June, 2026 (https://github.blog/changelog/2026-05-14-github-actions-upcoming-image-migrations/#windows-2025-visual-studio-2026-image-migration).This PR updates the Visual Studio path based on https://github.com/actions/runner-images/blob/main/images/windows/Windows2025-VS2026-Readme.md#visual-studio-enterprise-2026. This update is necessary, otherwise the CI can't find Visual Studio and use MinGW GCC to compile the source code.
It's weird. The CI still can't find VS correctly (xref: https://github.com/GenericMappingTools/pygmt/actions/runs/32818816716/job/97712485125?pr=4860), but a similar fix in the GMT repository seems to be working (https://github.com/GenericMappingTools/gmt/actions/runs/32817632151/job/97709027710?pr=9144)