Session.get_common: Fix the return values for options B/J/U/g/n/p/s and improve option checking - #4862
Open
seisman wants to merge 1 commit into
Open
Session.get_common: Fix the return values for options B/J/U/g/n/p/s and improve option checking#4862seisman wants to merge 1 commit into
seisman wants to merge 1 commit into
Conversation
…nd improve option checking
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Session.get_commonchecks if an option is set and returns its value if possible.As shown below, it has bugs for some options. For examples, when
-fg/-figis used, it returnsTrue, while-fogreturns1.This PR fixes the bug. With the changes in this PR, it returns
0or1when set, andFalsewhen not set.Bugs detected and fixed by Claude, reviewed by @seisman