Skip to content

feat(dialtesting): extend Lightpanda browser checks - #204

Merged
leecha merged 1 commit into
mainfrom
feat/lightpanda-browser-dialtesting
Aug 12, 2026
Merged

feat(dialtesting): extend Lightpanda browser checks#204
leecha merged 1 commit into
mainfrom
feat/lightpanda-browser-dialtesting

Conversation

@NaR82n

@NaR82n NaR82n commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

What changed

  • add wait_for_url and make URL/title/text assertions poll until their step or script timeout
  • pass Lightpanda custom CA file/directory arguments while preserving a separate detected system CA directory
  • add Lightpanda HTTP proxy support with task > script > node-default precedence
  • add explicit private-network blocking and exact CIDR blocking options
  • document the new task options and action behavior

Why

DataKit browser dial testing needs reliable redirect polling, enterprise CA trust, proxy routing, and browser-level private-network enforcement when running the Lightpanda 0.3.6-g2 build. Keeping these capabilities in cliutils avoids downstream modifications to vendored source.

Impact

Existing zero-value Lightpanda runner behavior remains unchanged. The new Lightpanda flags are only added when the corresponding runtime options are set. Assertions now wait for eventual consistency until timeout instead of failing on the first observation.

Validation

  • go test ./dialtesting/browserdial/... -count=1
  • Linux container: go test ./dialtesting/... -count=1
  • Linux container: go vet ./dialtesting/...
  • golangci-lint run --fix ./dialtesting/browserdial/... (0 issues)
  • python copyright.py --dry-run
  • git diff --check

Full-repository lint on the Windows host is blocked by existing platform-specific system syscall type-check errors; the changed browserdial packages lint cleanly.

@leecha
leecha self-requested a review August 12, 2026 02:48
@leecha
leecha marked this pull request as ready for review August 12, 2026 03:03
@leecha
leecha merged commit 4ed7579 into main Aug 12, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants