Ballot notes pass for Resources - #4284
Merged
Merged
Conversation
lmckenzi
reviewed
Jul 17, 2026
lmckenzi
left a comment
lmckenzi
left a comment
Contributor
There was a problem hiding this comment.
- Inconsistent ballot-note markup. Most files use
<div><blockquote class="ballot-note" id="bnN">…</blockquote></div>, butsource/resource/resource-introduction.xmlandsource/domainresource/domainresource-introduction.xmluse<div class="ballot-note" id="bn5">…</div>with noblockquote. Does the second one render correctly? - Empty
idattribute.source/searchparameter/searchparameter-introduction.xmlintroduces<blockquote class="ballot-note" id="bn">— theidvalue is empty; likely intendedbn2(or similar). Dunno if this is an issue - Editorial leakage.
source/auditevent/auditevent-introduction.xmlstill contains the sentence "…includes unattributed mapping/follow-up cleanup that reviewers should tie to Jira before publication." That reads as an internal note; should it be visible to balloters?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HL7 FHIR Pull Request
Note: No pull requests will be accepted against
./sourceunless logged in the HL7 Jira issue tracker.If you made changes to any files within
./sourceplease indicate the Jira tracker number this pull request is associated with:Description
Pass of ballot-notes for resources. Note that I have NOT reviewed pages for the same.
Build is same as master, with additional
file "*-introduction.xml": div/div[0] must start with an h2for many ballot comments.