fix: show the real signup error instead of "Unexpected Error" - #345
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
DaStormer
self-requested a review
September 15, 2026 15:10
DaStormer
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was done
res_json.bodycheck inSignUpwithres_json.messageinapp/lib/actions.tssignupErrorMessagehelper that maps the errors/createreturns to clearer signup messagesUnexpected Erroronly when the backend sends no messageWhy
Every failed signup was showing
Unexpected Error.The frontend was reading
res_json.body, butbodyis part of the Lambda → API Gateway response envelope. API Gateway consumes that wrapper, so the frontend actually receives:That meant
res_json.bodywas always undefined and every failure fell back to the generic error.This change reads
messageinstead and maps the known/createerrors to clearer, actionable messages. Matching uses lowercased substrings rather than exact strings because the backend wiki and handler differ slightly in wording.Closes #342