Skip to content

Docker-Compose setup added to project - #156

Closed
jpglord wants to merge 4 commits into
InkProject:masterfrom
jpglord:master
Closed

Docker-Compose setup added to project#156
jpglord wants to merge 4 commits into
InkProject:masterfrom
jpglord:master

Conversation

@jpglord

@jpglord jpglord commented Aug 16, 2026

Copy link
Copy Markdown

docker-compose up no longer works out of the box with the project as it currently stands on GitHub.

Fixed the Go version in the Dockerfile (1.18 → 1.25)
Modernized some code using go run golang.org/x/tools/go/analysis/passes/modernize/cmd/modernize@latest -fix ./...
Added stdin/stdout error checking to the infinite loop in main, panicking when an error is received from stdin or stderr

jpglord and others added 3 commits August 16, 2026 15:29
Adds docker-compose.yml + entrypoint.sh so `docker-compose up` works
from a bare clone: the entrypoint scaffolds a blog from the bundled
template if ./builds is missing, and independently re-clones the
ink-theme-dark theme if that's missing, so the container can never
fail to boot for a missing workspace or theme.

Also commits the actual builds/ blog workspace (config.yml, source/,
vendored ink-theme-dark theme) so it's never only on disk — repeated
docker-compose down/up cycles kept resetting the bind-mounted folder
during testing.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…un ./... runned for fix and stdin stderr check added to main
@w568w
w568w self-requested a review August 16, 2026 13:31
@w568w

w568w commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

Some obvious things I note:

  1. Please exclude your builds/ from the patch;
  2. What do you mean by "docker-compose up no longer works out of the box"? We have never got a docker-compose.yml in the repository yet.

@jpglord

jpglord commented Aug 17, 2026

Copy link
Copy Markdown
Author

Thanks for the review!

  1. Removed builds/ from the patch and added it to .gitignore so it
    won't be tracked going forward.

  2. Sorry for the confusion — that line was misleading. There's no
    docker-compose.yml in this repo; I meant the Docker build itself.
    The root cause: go.mod requires go 1.25.0, but the Dockerfile was
    pinned to golang:1.18, which fails with
    "go.mod requires go >= 1.25.0 (running go 1.18.x)". Bumped the base
    image to golang:1.25 to fix it.

Pushed in 18b8118.

Additionally, I added a couple of small extras while I was in there:

  • A ./ink b alias for quicker builds
  • Shell autocompletion support via source <(./ink completion bash)

Happy to split these into a separate PR if you'd rather keep this one
focused — just let me know. Let me know if anything else needs changing.

@w568w

w568w commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

I'm detecting a heavy trace of AI slop in this code. Although this project doesn't have a zero-AI policy:

  1. Please review your code at least once before submitting. After my previous critique, it seems to have exhibited the typical traits of current AI: it instantly became overly defensive, adding dozens of lines of comments everywhere just to explain to the void that it "has no builds," "has already excluded builds," or "the following line of blabla code is meant to exclude builds." These comments are entirely pointless, serving no purpose other than trying to claim credit from an imaginary reviewer.

  2. I didn't quite follow the changes regarding PUID and PGID. Could you explain in detail what the issue was there?

I have no objections to the modernization efforts, the Dockerfile updates, or the addition of the docker-compose.yml file. However, you (or your AI) can do better.


Also, it's not a great pleasure to talk with an AI - If I want to discuss with an AI, I can copy & paste the PR description into my own Coding Agent and do the changes by myself. Please use translation tools if necessary.

@jpglord jpglord closed this Aug 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants