Skip to content

feat(SDK-749): embedded messaging sync success and failure callbacks - #908

Draft
jferrao-itrbl wants to merge 3 commits into
feature/SDK-548-feature-parityfrom
feature/SDK-749-success-failure-callbacks
Draft

jferrao-itrbl wants to merge 3 commits into
feature/SDK-548-feature-parityfrom
feature/SDK-749-success-failure-callbacks

Conversation

@jferrao-itrbl

Copy link
Copy Markdown
Collaborator

Summary

  • Bridge native embedded sync outcomes to IterableConfig.onEmbeddedMessagingSyncSucceeded and onEmbeddedMessagingSyncFailed via device events (no TurboModule changes).
  • Forward nullable failure reason strings from iOS/Android; add iOS *Present flags so sync-only configs register the embedded update listener.
  • Document platform nuance (subscription-inactive / invalid API key) in CHANGELOG.

Test plan

  • yarn typecheck
  • yarn test src/core/classes/Iterable.test.ts
  • Manual: embedded sync success/failure on iOS and Android example app (optional)

Expose IterableConfig sync success/failure handlers via native events
so apps can observe embedded sync outcomes.
@jferrao-itrbl
jferrao-itrbl requested a review from a team as a code owner September 27, 2026 14:32
@github-actions

github-actions Bot commented Sep 27, 2026 •

Copy link
Copy Markdown
Lines Statements Branches Functions
Coverage: 72%
72.7% (602/828) 62.62% (243/388) 68.04% (181/266)

@qltysh

qltysh Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

Qlty


Coverage Impact

Unable to calculate total coverage change because base branch coverage was not found.

Modified Files with Diff Coverage (1)

RatingFile% DiffUncovered Line #s
New file Coverage rating: A
src/core/classes/Iterable.ts100.0%
Total100.0%
🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@jferrao-itrbl
jferrao-itrbl marked this pull request as draft September 27, 2026 14:33
Assert sync handlers stay separate from message-update events and
respect enableEmbeddedMessaging when callbacks are omitted or set.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant