Skip to content

docs: fix DatabaseFactory.create() call signature - #68

Merged
JarbasAl merged 2 commits into
devfrom
docs/fix-databasefactory-create-signature
Sep 7, 2026
Merged

docs: fix DatabaseFactory.create() call signature#68
JarbasAl merged 2 commits into
devfrom
docs/fix-databasefactory-create-signature

Conversation

@JarbasAl

@JarbasAl JarbasAl commented Sep 5, 2026

Copy link
Copy Markdown
Member

🤖 Auto-generated by Claude Sonnet 5 (claude-sonnet-5) via Claude Code — NOT human-reviewed. Verify before acting.

docs/operations.md showed a cross-backend migration example calling
DatabaseFactory.create("hivemind-redis-db-plugin", config={"host": ..., "port": ...}).
The real signature (hivemind_plugin_manager/__init__.py, DatabaseFactory.create) takes
host and port as direct keyword arguments; there is no config parameter. Running the
documented snippet against the current hivemind-plugin-manager (checked against the local
editable install, 0.9.0a6, and the origin/dev source) raises:

TypeError: DatabaseFactory.create() got an unexpected keyword argument 'config'

Fixed the example to pass host= and port= directly. No other claim in this repo's README
or docs/ (entry-point name, config keys and defaults, schema version, migration behavior) was
found to be inaccurate against source.

DatabaseFactory.create() takes host/port as direct keyword arguments,
not a config dict. The documented example raised TypeError.
@coderabbitai

coderabbitai Bot commented Sep 5, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 5, 2026

Copy link
Copy Markdown

The automated sentinels have completed their watch. 💂‍♂️

I've aggregated the results of the automated checks for this PR below.

🔍 Lint

The results have been compiled and are ready for review. 📑

ruff: issues found — see job log

🔒 Security (pip-audit)

Ensuring our code is secure by design. 📐

✅ No known vulnerabilities found (70 packages scanned).

⚖️ License Check

Ensuring our EULA (if any) is still valid. 📑

✅ No license violations found.

Policy: Apache 2.0 (universal donor). StrongCopyleft / NetworkCopyleft / WeakCopyleft / Other / Error categories fail. MPL allowed.

📋 Repo Health

The repo's annual physical is complete! 🩺

✅ All required files present.

Latest Version: 0.4.3a8

hivemind_sqlite_database/version.py — Version file
README.md — README
LICENSE.md — License file (consider renaming to LICENSE)
pyproject.toml — pyproject.toml
⚠️ setup.py — setup.py
CHANGELOG.md — Changelog
hivemind_sqlite_database/version.py has valid version block markers

🏷️ Release Preview

I've checked the countdown clock for the next release. ⏰

Current: 0.4.3a8Next: 0.4.3a9

Signal Value
Label (none)
PR title docs: fix DatabaseFactory.create() call signature
Bump alpha

✅ PR title follows conventional commit format.


🚀 Release Channel Compatibility

Predicted next version: 0.4.3a9

Channel Status Note Current Constraint
Stable Not in channel -
Testing Not in channel -
Alpha Compatible hivemind-sqlite-database>=0.4.3a7

📊 Coverage

A comprehensive review of our code coverage. 📖

85.6% total coverage

Per-file coverage (2 files)
File Coverage Missing lines
hivemind_sqlite_database/version.py 0.0% 5
hivemind_sqlite_database/__init__.py 87.8% 24

Full report: download the coverage-report artifact.

🔨 Build Tests

Assembling the puzzle pieces of your PR. 🧩

Python Build Install Tests
3.10 ⚠️
3.11 ⚠️
3.12 ⚠️
3.13 ⚠️
3.14 ⚠️

❌ 3.10: Install OK, tests failed
❌ 3.11: Install OK, tests failed
❌ 3.12: Install OK, tests failed
❌ 3.13: Install OK, tests failed
❌ 3.14: Install OK, tests failed
Check job logs for details.


Crafting a better voice assistant, one commit at a time 🎙️

@JarbasAl
JarbasAl marked this pull request as ready for review September 7, 2026 17:25
@JarbasAl
JarbasAl merged commit 3c0ea70 into dev Sep 7, 2026
14 checks passed
@JarbasAl
JarbasAl deleted the docs/fix-databasefactory-create-signature branch September 7, 2026 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant