fix: runtime-patch verify skips unused wrapper smoke (#32) - #41
Merged
Merged
Conversation
verify no longer fails because leftover wrapper --help cannot find vendor needles on an in-place patched glm/zcode.cjs. recover reapplies the patch and bootstraps dropped LaunchAgents. Shared series-eval cell IDs land in breaktest/series-bank.txt.
The leftover wrapper --help path execs NODE_COMMAND. The fixture node is a shebang stub, which CreateProcess rejects (WinError 193). Import patched_runtime_path instead of spawning node.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #32.
runtime-patch 模式下 leftover wrapper 会从已打补丁的
glm/zcode.cjs反推原始锚点,verify恒失败,和doctor.patched矛盾。verify在 runtime-patch 下默认跳过 wrapper--helpsmoke;判据改为zcode_runtime_patched+competing_context(CLI-prefix / OVERRIDE / MEMORY skip)。--smoke仍可强制跑。runtime_original_backup,或直接放行已含ZCODE_KEYSMITH_SYSTEM_FILE的 runtime。recover:预览/重打补丁、补 follow-up、bootstrap 掉出 GUI 会话的 LaunchAgent。锚点不认识或 plist 缺失则失败关闭。breaktest/series-bank.txt/docs/series-eval.md。0.3.3 仍待发 tag。合入后请打
v0.3.3并挂 zip + SHA256SUMS。