fix for self-closing tags - #2
Open
davidgith1 wants to merge 3 commits into
Open
Conversation
test case for empty self closed tags
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initally proposed this fix here but this fix makes more sense in the lib.
My previous explanation:
I'm using koreader + comicmeta on Android.
The important part is that is has at least one self closing tag:
Comic metadata extraction complete. Successfully extracted 0 / 1No errors and nothing extracted.
After this fix, a ComicInfo.xml like the examples above will result in a successful extraction.
The self-closing tags come back as tables so it fails when the plugin is expecting a string. This fix make them come back as an empty string instead.