Make certain optional features actually disablable - #425
Draft
scj643 wants to merge 1 commit into
Draft
Conversation
Also moved FACTORY_TEST_ENABLE and RETAIL_DEMO_ENABLE to their own lines.
Author
|
Actually it's closer to 3k with both disabled and LTO enabled. |
lokher
force-pushed
the
2025q3
branch
4 times, most recently
from
April 14, 2026 10:21
a5e4148 to
7c2357c
Compare
EKl40
approved these changes
Jul 20, 2026
EKl40
left a comment
EKl40
left a comment
There was a problem hiding this comment.
I see nothing wrong with this. It shouldn’t be marked as a draft, since none of the force-pushes mentioned above introduced any conflicts.
Author
|
I'll have to look at it because I think there was some things I needed to validate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR to make it easier to disable unwanted features.
Disabling
FACTORY_TESTandRETAIL_DEMO_ENABLEcan save a bit over 1kb of space.