Updating Reading stats - #121
Open
dannoh wants to merge 22 commits into
Open
Conversation
|
coverage: 61.519% (+5.5%) from 56.065% — dannoh:ReadingStats into GeorgeSG:master |
Reading stats
Catching and reseting IsLoading if cover search fails
Local docker
Local deploy example
Reading stats fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the streaks discussed in #47
Actual Implementation
One question is on sizing. The way it works now the sizing can look a little strange if one of the stat cards wraps to a new line it takes up the whole line. Could go to fixed width for the cards so they are more uniform. Would look like this?
Hypothetical Implementation
Looking for feedback on the card layout and icon choices especially.