KDocs for min/max - #2012
Merged
Merged
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as low quality.
This comment was marked as low quality.
Jolanrensen
requested review from
Allex-Nik and
AndreiKingsley
and removed request for
Allex-Nik and
AndreiKingsley
July 30, 2026 13:40
AndreiKingsley
requested changes
Jul 31, 2026
AndreiKingsley
left a comment
AndreiKingsley
left a comment
Collaborator
There was a problem hiding this comment.
I am not sure about maxBy/maxFor descriptions — they look complicated (especially for maxByOrNull), and hard to understand difference. May be slightly rephrase/restructurize them.
Also it's hard to get confused about max()/maxFor { }/max { } , I'd emphasise differences/commons between them.
Please add links to pivot/groupBy grammars.
Make comments in examples code more detailed.
Allex-Nik
reviewed
Aug 1, 2026
Allex-Nik
reviewed
Aug 1, 2026
Allex-Nik
reviewed
Aug 1, 2026
Allex-Nik
reviewed
Aug 2, 2026
Allex-Nik
reviewed
Aug 2, 2026
Allex-Nik
reviewed
Aug 3, 2026
Allex-Nik
reviewed
Aug 3, 2026
Allex-Nik
left a comment
Allex-Nik
left a comment
Collaborator
There was a problem hiding this comment.
Left a couple of comments, otherwise it looks good to me :)
Jolanrensen
force-pushed
the
min-max-docs
branch
from
August 4, 2026 11:33
befa96f to
e67195d
Compare
…mpty columns, instead return null, like -For, and -By and the KDocs
Jolanrensen
force-pushed
the
min-max-docs
branch
from
August 4, 2026 18:57
28e92e5 to
5bdf017
Compare
Allex-Nik
self-requested a review
August 5, 2026 11:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1971, #1974
I let Claude attempt write it using all our KDoc guides. It's quite impressive!
Only made some small fixes and maintainability improvements, but it looks good to me. All questions I had are answered in the KDocs and it seemed to understand and use KoDEx quite well.