Tests refactorings: simplify enabling compiler plugin in :core - #2058
Open
koperagen wants to merge 2 commits into
Open
Tests refactorings: simplify enabling compiler plugin in :core#2058koperagen wants to merge 2 commits into
koperagen wants to merge 2 commits into
Conversation
We don't support local dataschema declarations
koperagen
added
the
tests
![jetbrains-air[bot]](https://avatars.githubusercontent.com/in/3314082?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Clean, behavior-preserving test refactoring — happy to approve!
Produced by AIR Automations. Name: AI Review / Run: https://air.jetbrains.cloud/org/05cf1a7f-6ab5-713b-abd3-29d0c8a05e2d/automations/8daf2412-0b6c-4433-90c0-b40ab5aebcdb?run=5875a403-2055-4939-a465-30193c9b0b94
Contributor
There was a problem hiding this comment.
Looks good — clean, semantics-preserving test refactor, happy to approve! 🎉
Produced by AIR Automations. Name: AI Review / Run: https://air.jetbrains.cloud/org/05cf1a7f-6ab5-713b-abd3-29d0c8a05e2d/automations/8daf2412-0b6c-4433-90c0-b40ab5aebcdb?run=83dda412-d42a-473b-a740-d8e2f361280b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
note: i sometimes enable plugin in :core on a branch for manual testing of the plugin. local data schemas prevent compilation