Capture VM SSH host keys on the periodic fleet check - #346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #344.
capture_vm_ssh_host_keysonly ran fromcheck_vm, which is dispatched on customer action, so a VM nobody touched never got keys. It now also runs in the 30s fleet sweep (worker.rs:1198-1201), next to the DNS reconcile that was already there.No backfill job: the sweep visits every non-deleted VM, capture no-ops once complete and self-throttles retries hourly, so the fleet heals itself.
Test asserts the sweep reaches capture via the recorded attempt stamp; it fails without the one-line change.
Originating channel: general (721a8a6c-c36c-5fa1-ae07-822ddc8567c5)