Send the billing interval with a custom VM price - #347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #302.
POST /api/v1/vm/custom-template/pricenow returnsinterval_amountandinterval_typealongsidecurrency/amount(lnvps_api/src/api/model.rs:55-90), matching the shape a standard template cost plan already uses. Values are always 1/month.The period was only implicit in the renewal (
pricing.rs:891-895); it is now a constant both that and the quote read, with a const assert so the unit cannot drift from the months-based renewal.e2e asserts the fields on a 200 response.
API_CHANGELOG.mdupdated; additive, no existing field changed.Originating channel: general (721a8a6c-c36c-5fa1-ae07-822ddc8567c5)