simplifySubset() bug (unrelated root) - #1052
Merged
Merged
Conversation
Issue #1428
labkey-jeckels
left a comment
labkey-jeckels
left a comment
Contributor
There was a problem hiding this comment.
Did you run /review-lk on this yet? It had some suggestions that I don't know the scenario well enough to really evaluate.
Contributor
Author
Claude didn't have much useful to say, but I noticed that the result of simplySubset() is now asymmetric, which seemed wrong. This was a regression do to previous "linting" of the code. |
labkey-jeckels
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Handle unrelated roots
Issue #1428
Related Pull Requests
Changes
Tasks 📍