Issue 1324: Pass through audit comments to ExperimentListener on sample type and source type deletion - #7934
Open
labkey-susanh wants to merge 7 commits into
Open
Issue 1324: Pass through audit comments to ExperimentListener on sample type and source type deletion#7934labkey-susanh wants to merge 7 commits into
labkey-susanh wants to merge 7 commits into
Conversation
This was referenced Aug 12, 2026
XingY
approved these changes
Aug 13, 2026
| try (DbScope.Transaction transaction = ensureTransaction()) | ||
| { | ||
| truncateDataClass(dataClass, user, null); | ||
| if (transaction.getAuditEvent() == null) |
Contributor
There was a problem hiding this comment.
Is this the best place to handle transaction audit event, should this be instead done at ExperimentController.AbstraceDeleteAction? That would also making wiring up getTransactionAuditDetails() easier.
Contributor
Author
There was a problem hiding this comment.
Good idea. Done.
|
|
||
| try (DbScope.Transaction transaction = ensureTransaction()) | ||
| { | ||
| if (transaction.getAuditEvent() == null) |
Contributor
There was a problem hiding this comment.
Wouldn't need to duplicate this here if done in ExperimentController.AbstraceDeleteAction
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Issue 1324 When a sample type or source type is deleted, the samples or sources should be removed from any jobs that reference them since otherwise those job entities become orphaned, showing up in counts but never surfacing in the UI with no way for users to get rid of them. We want to pass through the audit comment provided for the type deletion.
Related Pull Requests
Changes
beforeMaterialDeleteandbeforeDataDeleteto accept a nullableauditUserComment