Support setting SMTP timeouts in application.properties - #1465
Merged
Conversation
labkey-jeckels
approved these changes
Aug 11, 2026
| // GitHub Issue #1416 - default values for SMTP timeouts | ||
| put("mail.smtpConnectionTimeout", 10 * 1000); | ||
| put("mail.smtpTimeout", 60 * 1000); | ||
| // Unlike the socket-level timeouts above, JavaMail implements writetimeout with a ScheduledThreadPool per connection - one per message, since Transport.send() doesn't pool |
Contributor
There was a problem hiding this comment.
Is this comment helpful?
Contributor
Author
There was a problem hiding this comment.
Claude was insistent. It did inspire some ideas that I documented here: https://github.com/LabKey/internal-issues/issues/1438
Contributor
There was a problem hiding this comment.
Feel free to tell Claude I find it irrelevant.
labkey-adam
added a commit
to LabKey/platform
that referenced
this pull request
Aug 13, 2026
## Rationale Having two places to configure SMTP properties (`application.properties` and startup properties) leads to confusion and uncertainty over merge/override behavior. Simplify to one place: application.properties. We believe no one is configuring SMTP via startup properties, but I'm leaving the startup property handler in place for now to provide a clear error message and fail startup. We can remove that on develop. ## Related Pull Requests - LabKey/server#1465
labkey-adam
added a commit
to LabKey/testAutomation
that referenced
this pull request
Aug 13, 2026
## Rationale Testing default values for these new properties ## Related Pull Requests - LabKey/server#1465
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Lack of SMTP timeouts can lead to unresponsive servers:
Changes
MailProperties->StandardContextLabKeyServertoLabKeyTomcatServletWebServerFactory(the one place where they're used)