Repository navigation
GH Issue 1707: Test assay transform callbacks during folder delete - #3251
Merged
Merged
Conversation
labkey-tchad
approved these changes
Oct 19, 2026
labkey-klum
approved these changes
Oct 19, 2026
labkey-jeckels
added a commit
to LabKey/platform
that referenced
this pull request
Oct 22, 2026
…ion (#8183) ## Rationale Assay imports held a database transaction open while the transform script ran, with no time limit, so a script that calls back into the server could deadlock with a concurrent folder delete ([GH Issue 1707](LabKey/internal-issues#1707), see also GH Issue 1539). Standard (GPAT) assays now run their transform scripts before the transaction begins and record the results inside it, and all transform scripts get a site-wide timeout. SaveAssayBatch/SaveAssayRuns ([GH Issue 1720](LabKey/internal-issues#1720)) and the other assay providers (Luminex, NAb, etc.) still run scripts inside the transaction and are follow-ups. ## Related Pull Requests - LabKey/testAutomation#3251 ## Changes - Split transform handling into an execute step with no database writes and a record step that writes the script's outputs against the saved run - importRun.api, the upload wizard, and background pipeline imports run GPAT transform scripts before opening the transaction; plate-metadata designs keep the old behavior - Transform scripts run without the protocol import lock, so concurrent imports can run their scripts in parallel; the lock is held only while the run is saved - Each import tracks its own transform working directory, so concurrent imports no longer share one - New site setting for the transform script timeout, default 60 minutes - Fix run name and comments set by a transform script never being saved - Background imports from dataRows now save the rows to a file instead of failing with an NPE; explicitly passing saveDataAsFile=false is rejected with a clear error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Adds coverage for GH Issue 1707: a GPAT transform script that calls back into the server must not block, or be blocked by, a concurrent folder delete.
Coverage for the batch and run save APIs follows with GH Issue 1720.
Related Pull Requests
Changes