Conversation
|
@Ziusz — thank you for this, and sorry it sat so long without a word. You spotted both of these from someone else's diagnostic output in #272, which is a generous way to spend your time. Both were real:
Both have since been fixed in the tree, independently of this PR — which means you found them first and we duplicated your work while this sat unreviewed. The udev one is now pinned in So the credit for spotting both is yours even though the diff that landed isn't. I'm leaving this open for you to close or rebase as you prefer — it's your PR. Thanks for caring about someone else's report enough to fix it. |
|
Thank you for this one, and sorry it sat. Two of its three fixes had already reached Closing this PR as superseded since everything in it is now on If this project helps you, consider buying me a beer 🍺 or Ko-fi ☕ |
…reads udev(7) reads rules from four directories: /usr/lib, /usr/local/lib, /run and /etc. The health check looked in /etc, /lib and /usr/lib, so a rule installed by a `make install` under /usr/local, or generated into /run, was reported as "No TRCC udev rules found" -- #258's defect again, in two locations its fix did not cover. PR #273 (@Ziusz) found both. The directory list now lives beside RULES_PATH in _udev.py as RULES_DIRS, and the check derives its candidates from it; the docstring and the WARN message no longer claim the check looks only under /etc. Two tests, because one is not enough: the existing parametrized test now runs over RULES_DIRS rather than a hand-typed pair of directories, which pins that the check USES the constant (mutate the check to ignore it: 4 cases fail) -- but it cannot notice a directory missing FROM the constant, since its cases come from the constant (drop /run: the case disappears, 8 pass). So a second test restates udev(7)'s four directories as the oracle and requires RULES_DIRS to cover them (drop /run: it fails). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Summary
Small cleanup for two misleading sections in
trcc report. Both issues were spotted in the diagnostic output attached to #272.Changes:
trcc.jsoninstead of the oldconfig.jsonpath99-trcc-lcd.rulesin the standard system, runtime, local, and distro package locations99-trcc.rulesname to the current99-trcc-lcd.rulesfilenameThis prevents existing settings files and udev rules from being incorrectly reported as missing.
Checklist
pytest -v --tb=short)ruff check .)