Conversation
Signed-off-by: YvesCesar <yvesamorim73@gmail.com>
vitormattos
reviewed
Sep 26, 2026
vitormattos
requested changes
Sep 26, 2026
Signed-off-by: YvesCesar <yvesamorim73@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #6.
Nothing kept the tests next to the code they cover, or the covered lines from going down.
Test layout
tests/Unit/StructureTest.phpfails when a plugin file has no test named after it, or when a test no longer has its file:tests/Integration/WpSimpleSmtpTest.php;src/needs a test with the same name intests/Unitortests/Integration;tests/E2E(test: cover sending mail through smtp end to end with playwright #7) needs the plugin file it is named after.It runs in the unit suite, without WordPress.
tests/Support/PluginFiles.phplists the files. Checked: a newsrc/file without a test, a unit test without itssrc/file and a spec with no matching plugin file each fail; the spec from #7 passes.Coverage
composer coverageruns both suites with Xdebug over the main file andsrc/, and writestests/.coverage/clover.xml. Today it measures 100% (119 of 119 lines).Coveragejob inphpunit.ymlruns it on PHP 8.3 and hands the report to octocov..octocov.ymlfails the run when coverage is below 95% or below the last report ofmain, which octocov keeps as a workflow artifact.k1LoW/octocov-actionis pinned by SHA (v1.5.2) and itsversioninput to octocovv0.80.1, so neither the action nor the binary changes between runs.The README lists the layout rule and the coverage floor.