Skip to content

build(Linux): add aarch64 AppImage - #5627

Merged
ReenigneArcher merged 2 commits into
masterfrom
build/linux/add-aarch64-AppImage
Sep 6, 2026
Merged

build(Linux): add aarch64 AppImage#5627
ReenigneArcher merged 2 commits into
masterfrom
build/linux/add-aarch64-AppImage

Conversation

@ReenigneArcher

@ReenigneArcher ReenigneArcher commented Sep 6, 2026

Copy link
Copy Markdown
Member

Description

Adds AppImage for aarch64.

TODO:

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

See our AI usage policy.

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@codecov

codecov Bot commented Sep 6, 2026

Copy link
Copy Markdown

Bundle Report

Bundle size has no change ✅

@ReenigneArcher
ReenigneArcher force-pushed the build/linux/add-aarch64-AppImage branch from 337362a to 35a7348 Compare September 6, 2026 02:43
Comment thread .github/workflows/ci-linux.yml Fixed
Comment thread .github/workflows/ci-linux.yml Fixed
Comment thread .github/workflows/ci-linux.yml Fixed
@ReenigneArcher
ReenigneArcher force-pushed the build/linux/add-aarch64-AppImage branch 2 times, most recently from 89676a6 to 3e13404 Compare September 6, 2026 03:38
Comment thread .github/workflows/ci-linux.yml Fixed
Comment thread .github/workflows/ci-linux.yml Fixed
Comment thread .github/workflows/ci-linux.yml Fixed
@ReenigneArcher
ReenigneArcher force-pushed the build/linux/add-aarch64-AppImage branch from 3e13404 to 99bd6f6 Compare September 6, 2026 04:05
Comment thread .github/workflows/ci-linux.yml Fixed
Comment thread .github/workflows/ci-linux.yml Dismissed
@codecov

codecov Bot commented Sep 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 37.41%. Comparing base (af505b7) to head (0ae50ce).
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5627      +/-   ##
==========================================
+ Coverage   37.33%   37.41%   +0.08%     
==========================================
  Files         104      104              
  Lines       25948    25950       +2     
  Branches    11450    11459       +9     
==========================================
+ Hits         9687     9709      +22     
+ Misses      14100    13393     -707     
- Partials     2161     2848     +687     
Flag Coverage Δ
Archlinux 20.92% <ø> (ø)
FreeBSD-amd64 23.24% <ø> (-0.01%) ⬇️
Homebrew-macos-14 36.35% <ø> (ø)
Homebrew-macos-15 36.92% <ø> (ø)
Homebrew-macos-26 37.23% <ø> (ø)
Homebrew-ubuntu-24.04 24.93% <ø> (ø)
Linux-AppImage ?
Linux-AppImage-aarch64 25.49% <ø> (?)
Linux-AppImage-x86_64 25.70% <ø> (?)
Windows-AMD64 30.10% <ø> (ø)
Windows-ARM64 25.23% <ø> (-0.01%) ⬇️
macOS-arm64 30.68% <ø> (ø)
macOS-x86_64 31.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 39 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af505b7...0ae50ce. Read the comment docs.

@github-actions

github-actions Bot commented Sep 6, 2026

Copy link
Copy Markdown
Last Updated 2026-09-06 13:10:02 UTC
Source Run CI Run #5325
Commit e3ba5c271fe3b59570bed506a308885a8e8e73d9

Screenshot Comparison

PR #5627 screenshots vs screenshots baseline.

Matrix: AppImage

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: AppImage-aarch64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: Windows-AMD64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: Windows-ARM64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: macOS-arm64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: macOS-x86_64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Move Python setup earlier and switch AppImage verification from downloading the x86_64 AppImage binary to installing `appimagelint` via pip from the `feat/aarch64` branch. This removes the x86_64-only condition so linting runs for all AppImage matrix entries and avoids duplicate Python setup later in the job.
@ReenigneArcher
ReenigneArcher force-pushed the build/linux/add-aarch64-AppImage branch from e3ba5c2 to 0ae50ce Compare September 6, 2026 18:25
@ReenigneArcher
ReenigneArcher marked this pull request as ready for review September 6, 2026 18:26
@sonarqubecloud

sonarqubecloud Bot commented Sep 6, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
1 New issue
1 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@ReenigneArcher
ReenigneArcher merged commit aea2192 into master Sep 6, 2026
61 of 66 checks passed
@ReenigneArcher
ReenigneArcher deleted the build/linux/add-aarch64-AppImage branch September 6, 2026 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants