Genereer preview URL op basis van target branch - #95
Open
TimvdLippe wants to merge 14 commits into
Open
Conversation
Contributor
Author
|
PR waar een diff is naar main: Logius-standaarden/automatisering-test#17 |
TimvdLippe
commented
Aug 21, 2026
| if ${{ github.base_ref == 'develop' }}; then | ||
| echo "BASELINE_URL_DIFF=${{ env.ORGANISATION_URL }}/${{ github.event.repository.name }}" >> "$GITHUB_OUTPUT" | ||
| elif ${{ github.base_ref == 'main' }}; then | ||
| wget https://raw.githubusercontent.com/Logius-standaarden/Automatisering/baseline-url-diff/scripts/compute-published-url.mjs |
Contributor
Author
There was a problem hiding this comment.
TODO: Update naar main voordat we dit mergen
Contributor
Author
|
Laatste commit ook gecheckt. Naar main: Logius-standaarden/automatisering-test#19 |
sanderke
reviewed
Aug 25, 2026
sanderke
left a comment
sanderke
left a comment
Member
There was a problem hiding this comment.
Snelle oplossing :D
Nog een paar opmerkingen.
Contributor
Author
|
All tests:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Voor develop is dat de werkversie. Voor main is dat de gepubliceerde
versie. Hiervoor moest ook
compute-published-url.mjswordengeupdatet zodat die om kan gaan met een
.mjs. Het laat hetbestandje in als tekst, wat niet ideaal is, maar het werkt wel.
Fixes #94