Remove comments referencing invisible external context - #1699
Merged
sbryngelson merged 1 commit intoJul 30, 2026
Merged
Conversation
Three spots referenced context that means nothing to a reader of the public repo: - 10 occurrences of "(Feature N)" tags in toolchain/mfc/viz/tui.py, referencing a private feature checklist not present in this repo. Tags stripped, descriptive text kept. - An orphaned "Justification" comment in case_validator.py that reads like a leftover review note. - A migration note in params/definitions.py referencing a definitions/ directory that no longer exists. Fixes MFlowCode#1500
sbryngelson
approved these changes
Jul 29, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1699 +/- ##
=======================================
Coverage 61.04% 61.04%
=======================================
Files 83 83
Lines 20978 20978
Branches 3099 3099
=======================================
Hits 12807 12807
Misses 6126 6126
Partials 2045 2045 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
Fixes #1500. Three spots in the toolchain referenced context that means nothing to a reader of the public repo:
toolchain/mfc/viz/tui.py— 10 occurrences of(Feature N)/Feature N —tags referencing a private feature checklist not present in this repo. Tags stripped, descriptive text kept (capitalized where the tag had been the leading word of a docstring).toolchain/mfc/case_validator.py— removed an orphaned# Justification: ...comment sitting after the module docstring, which read like a leftover review note rather than documentation.toolchain/mfc/params/definitions.py— removed a migration-note sentence referencing adefinitions/directory that no longer exists in this repo.No logic changes; comment/docstring text only.
Testing/Review Recommendations
python3 -m py_compileon all three touched files passes.ruff format --checkpasses on all three files (no reformatting needed).ruff checkagainst.ruff.tomlreports 3 pre-existingPLR0917(too-many-positional-arguments) findings in this repo, all on function signatures I didn't touch (tui.py:451,tui.py:572,definitions.py:521) — confirmed these are present onmasteras well, unrelated to this change.AI Usage