Skip to content

OD-21529: Added support for Dooh xAPI extensions #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dplanalp-ghub wants to merge 4 commits into
base: main
Choose a base branch
from
Open

OD-21529: Added support for Dooh xAPI extensions #18

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9361389
OD-21529: Added support for Dooh xAPI extensions
dplanalp-ghub Aug 27, 2026
7dbd1ed
Revert "OD-21529: Added support for Dooh xAPI extensions"
dplanalp-ghub Aug 27, 2026
1e93f7b
OD-21529: Fixed formatting while preserving DOOH changes, also update…
dplanalp-ghub Aug 27, 2026
a528aee
OD-21529: Removed DoohExt from legacy location
dplanalp-ghub Sep 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions src/proto/com/magnite/openrtb/v2/openrtb-xapi.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ message ImpExt {
optional Window window = 2;

// Supported viewability vendors. For list of supported vendors, visit:
// https://resources.rubiconproject.com/resource/publisher-resources/xapi-specifications/#4.9.
// https://help.magnite.com/help/xapi-specifications-xapi-specifications.
repeated string viewabilityvendors = 3;

// Global Placement ID. The unique identifier of the placement that is sent
Expand All @@ -172,7 +172,7 @@ extend com.iabtechlab.openrtb.v2.BidRequest.Imp {
message VideoExt {
message Rp {
// DV+ size ID. Refer to
// https://resources.rubiconproject.com/resource/publisher-resources-2/supported-ad-formats.
// https://help.magnite.com/help/supported-ad-formats.
optional uint32 size_id = 1;
}

Expand Down Expand Up @@ -214,11 +214,11 @@ extend com.iabtechlab.openrtb.v2.BidRequest.Imp.Video {
message BannerExt {
message Rp {
// DV+ size ID. Refer to
// https://resources.rubiconproject.com/resource/publisher-resources-2/supported-ad-formats.
// https://help.magnite.com/help/supported-ad-formats.
optional uint32 size_id = 1;

// Alternate size IDs. Refer to
// https://resources.rubiconproject.com/resource/publisher-resources-2/supported-ad-formats.
// https://help.magnite.com/help/supported-ad-formats.
repeated uint32 alt_size_ids = 2;

// Specify the content type of ad markup (“adm” property) in the
Expand Down Expand Up @@ -266,7 +266,7 @@ message AppExt {

// An array of string identifiers denoting the advertiser blocklist
// relevant for this impression. See the DV+ Blocklist API for details:
// https://resources.rubiconproject.com/resource/publisher-resources/knowledge-base/blocklist-sync-api.
// https://help.magnite.com/help/blocklist-sync-api.
repeated string blocklists = 3;
}

Expand All @@ -291,7 +291,7 @@ message SiteExt {

// An array of string identifiers denoting the advertiser blocklist
// relevant for this impression. See the DV+ Blocklist API for details:
// https://resources.rubiconproject.com/resource/publisher-resources/knowledge-base/blocklist-sync-api.
// https://help.magnite.com/help/blocklist-sync-api.
repeated string blocklists = 3;
}

Expand Down Expand Up @@ -446,7 +446,7 @@ message NativeExt {
message Rp {
// DEPRECATED: no longer supported
// DV+ size ID. Refer to
// https://resources.rubiconproject.com/resource/publisher-resources-2/supported-ad-formats.
// https://help.magnite.com/help/supported-ad-formats.
optional uint32 size_id = 1 [deprecated = true];
}

Expand All @@ -472,7 +472,7 @@ extend com.iabtechlab.openrtb.v2.NativeRequest {
message AudioExt {
message Rp {
// DV+ size ID. Refer to
// https://resources.rubiconproject.com/resource/publisher-resources-2/supported-ad-formats.
// https://help.magnite.com/help/supported-ad-formats.
optional uint32 size_id = 1;
}

Expand Down Expand Up @@ -537,7 +537,7 @@ message BidExt {
optional string adtype = 3;

// DV+ size ID of winning ad size. Refer to
// https://resources.rubiconproject.com/resource/publisher-resources-2/supported-ad-formats.
// https://help.magnite.com/help/supported-ad-formats.
optional uint32 size_id = 4;

// Custom key/values used for targeting line items in a publisher ad
Expand All @@ -549,7 +549,7 @@ message BidExt {
optional uint32 creativeapi = 6;

// Supported viewability vendors. For list of supported vendors, visit:
// https://resources.rubiconproject.com/resource/publisher-resources/xapi-specifications/#4.9.
// https://help.magnite.com/help/xapi-specifications-xapi-specifications.
repeated string viewabilityvendors = 7;

// Indicates if the price is estimated (e.g., where pricing is not
Expand Down