Skip to content

fix(traces): keep the sticky table header above the Trace ID links - #1195

Merged
JeremyFunk merged 1 commit into
mainfrom
fix/traces-table-sticky-header-z
Oct 1, 2026
Merged

JeremyFunk merged 1 commit into
mainfrom
fix/traces-table-sticky-header-z

Conversation

@JeremyFunk

@JeremyFunk JeremyFunk commented Oct 1, 2026 •

Copy link
Copy Markdown
Collaborator

The Trace ID link is relative z-10 (to sit above the row's stretched link), the same level as the sticky thead, so later rows painted over the header while scrolling. Raise the header to z-20.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

Summary by CodeRabbit

  • Bug Fixes
    • Improved the traces table’s sticky header layering. While scrolling, the header now appears above the table content, making it easier to keep column labels in view as you move through the rows.

@maple-review-bot

maple-review-bot Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Maple review

🟢 Confidence 5/5 · safe to merge
quality 100/100 · no findings · tests not needed · risk low

Raises the sticky traces table header from z-10 to z-20 so scrolled rows no longer paint over it. A one-class CSS fix, safe to merge.

What was checked
  • Row tr is relative with no z-index, so the Trace ID link's z-10 (traces-table.tsx:266) compares directly against the header's new z-20
  • Grepped apps/web/src/components/traces for other z-10..z-50 elements inside the same scroll container: only the span detail panel's sticky tabs, a separate panel

5be79ee · Updated on every push. Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.

@coderabbitai

coderabbitai Bot commented Oct 1, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 872aa6cc-5a68-4544-b237-b5924646955c

📥 Commits

Reviewing files that changed from the base of the PR and between d3c1718 and 5be79ee.

📒 Files selected for processing (1)
  • apps/web/src/components/traces/traces-table.tsx
 _________________________________________________________________________________________________________________________________
< For a successful technology, reality must take precedence over public relations, for Nature cannot be fooled. - Richard Feynman >
 ---------------------------------------------------------------------------------------------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@JeremyFunk
JeremyFunk merged commit 5a6085d into main Oct 1, 2026
39 of 40 checks passed
@JeremyFunk
JeremyFunk deleted the fix/traces-table-sticky-header-z branch October 1, 2026 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant