Skip to content

fix(query-engine): regenerate the integrations SQL baseline - #1198

Merged
JeremyFunk merged 1 commit into
mainfrom
fix/main-ci-sql-catalog-snapshot
Oct 1, 2026
Merged

JeremyFunk merged 1 commit into
mainfrom
fix/main-ci-sql-catalog-snapshot

Conversation

@JeremyFunk

@JeremyFunk JeremyFunk commented Oct 1, 2026 •

Copy link
Copy Markdown
Collaborator

CI on main fails in packages/query-engine-integrations/src/benchmark/catalog.test.ts (snapshot mismatch), which also blocks the prd deploy gate.

#1196 and #1197 both touched the agent-sessions queries and merged back to back; the recorded baseline in __sql_baseline__/integrations.sql no longer matches the SQL the merged code emits.

Regenerated with vitest run src/benchmark/catalog.test.ts -u. Snapshot only, no query changes.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

@maple-review-bot

maple-review-bot Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Maple review

Nothing to review

Regenerates the recorded SQL baseline snapshot for the agent-session queries; the only changed file is generated test fixture data, so there is no production code to review.

What was checked
  • The only changed file is __sql_baseline__/integrations.sql, a generated fixture read by src/benchmark/catalog.test.ts:100
  • The new SQL matches the merged emitters: usageSpans/usageLinks in ai-span-columns.ts:167-180 and groupArrayArray(...)(usageReporters) in sessionReportersExpr

89e05e4 · Updated on every push. Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.

@coderabbitai

coderabbitai Bot commented Oct 1, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: b05d7af2-3ac9-4767-beff-110b390f8f37

📥 Commits

Reviewing files that changed from the base of the PR and between 7dfa83e and 89e05e4.

📒 Files selected for processing (1)
  • packages/query-engine-integrations/src/__sql_baseline__/integrations.sql
 ___________________________________________________
< Vibe code cleanup in progress... Expect swearing. >
 ---------------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@JeremyFunk
JeremyFunk merged commit f2e91c0 into main Oct 1, 2026
34 of 35 checks passed
@JeremyFunk
JeremyFunk deleted the fix/main-ci-sql-catalog-snapshot branch October 1, 2026 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant