fix(agent-sessions): loading-more row no longer squeezes the Session column - #1200
JeremyFunk wants to merge 1 commit into
Conversation
… so Session keeps its width
Maple review🟢 Confidence 5/5 · safe to merge Moves the "Loading more sessions…" indicator out of the sessions table so it no longer adds grid columns that squeeze the Session column, and hardens the browser test to assert it sits outside the table. Contained UI change, safe to merge.
What was checked
|
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review. 📝 WalkthroughWalkthroughThe additional-sessions loading indicator now renders in a div below the table. The browser test verifies that the indicator is outside the table. ChangesAgent session loading indicator
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The loading message stays visible during pagination without participating in the table layout. No material merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Problem
Scrolling to the end of the agent sessions list made the Session column collapse while the next page loaded.
The "Loading more sessions…" row was a
<td colSpan={10}>, one per declared column. Below 1270px of page width the container queries hide some of those columns, so the span reached past the visible ones and created extra grid columns. Undertable-fixedthose unsized columns split the leftover width with Session, the only other unsized column.Fix
Render the indicator as a
divunder the table, inside the same bordered box, so it never takes part in the column grid.Testing
agent-sessions-list.browser.test.tsx(11 pass), with an added assertion that the indicator sits outside the tableNeed help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by CodeRabbit