Skip to content

fix(agent-sessions): loading-more row no longer squeezes the Session column - #1200

Open
JeremyFunk wants to merge 1 commit into
mainfrom
fix/agent-sessions-loading-row-colspan
Open

JeremyFunk wants to merge 1 commit into
mainfrom
fix/agent-sessions-loading-row-colspan

Conversation

@JeremyFunk

@JeremyFunk JeremyFunk commented Oct 1, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

Scrolling to the end of the agent sessions list made the Session column collapse while the next page loaded.

The "Loading more sessions…" row was a <td colSpan={10}>, one per declared column. Below 1270px of page width the container queries hide some of those columns, so the span reached past the visible ones and created extra grid columns. Under table-fixed those unsized columns split the leftover width with Session, the only other unsized column.

Fix

Render the indicator as a div under the table, inside the same bordered box, so it never takes part in the column grid.

Testing

  • agent-sessions-list.browser.test.tsx (11 pass), with an added assertion that the indicator sits outside the table
  • Not checked visually in a running app

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

Summary by CodeRabbit

  • UI Improvements
    • The “Loading more sessions…” indicator now appears below the sessions table while additional sessions load.

@maple-review-bot

maple-review-bot Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Maple review

🟢 Confidence 5/5 · safe to merge
A single presentational move inside one component, with a browser test that fails if the indicator returns to the table.
quality 100/100 · no findings · tests covered · risk low

Moves the "Loading more sessions…" indicator out of the sessions table so it no longer adds grid columns that squeeze the Session column, and hardens the browser test to assert it sits outside the table. Contained UI change, safe to merge.

  • AgentSessionsList renders the loading indicator as a div below the table, inside the bordered box
What was checked
  • Virtualizer spacer rows and total-size math are unaffected by the sibling div (agent-sessions-list.tsx:442-466)
  • No stale assertion elsewhere: the row-count test renders without loadingMore (agent-sessions-list.browser.test.tsx:103)
  • Sentinel stays after the bordered box, still gated on hasMore (agent-sessions-list.tsx:572)

bcff5d3 · Updated on every push. Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.

@coderabbitai

coderabbitai Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 62cf3ec2-4586-4ef3-9747-84308ef8ba6c

📥 Commits

Reviewing files that changed from the base of the PR and between 43ac411 and bcff5d3.

📒 Files selected for processing (2)
  • apps/web/src/components/agent-sessions/agent-sessions-list.browser.test.tsx
  • apps/web/src/components/agent-sessions/agent-sessions-list.tsx

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.


📝 Walkthrough

Walkthrough

The additional-sessions loading indicator now renders in a div below the table. The browser test verifies that the indicator is outside the table.

Changes

Agent session loading indicator

Layer / File(s) Summary
Render and verify indicator placement
apps/web/src/components/agent-sessions/agent-sessions-list.tsx, apps/web/src/components/agent-sessions/agent-sessions-list.browser.test.tsx
The indicator moved from a table row to a div below the table. The browser test checks that its closest table is null.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Suggested reviewers: makisuo

Merge Risk: ⚪ Minimal · up to bcff5

The loading message stays visible during pagination without participating in the table layout. No material merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: moving the loading-more row to prevent the Session column from narrowing.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant