Bump plotly.js-dist-min from 3.7.0 to 4.0.0 in /frontend - #23
Closed
dependabot[bot] wants to merge 1 commit into
Closed
Bump plotly.js-dist-min from 3.7.0 to 4.0.0 in /frontend#23dependabot[bot] wants to merge 1 commit into
dependabot[bot] wants to merge 1 commit into
Conversation
Bumps [plotly.js-dist-min](https://github.com/plotly/plotly.js) from 3.7.0 to 4.0.0. - [Release notes](https://github.com/plotly/plotly.js/releases) - [Changelog](https://github.com/plotly/plotly.js/blob/main/CHANGELOG.md) - [Commits](plotly/plotly.js@v3.7.0...v4.0.0) --- updated-dependencies: - dependency-name: plotly.js-dist-min dependency-version: 4.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
MarlenMM
added a commit
that referenced
this pull request
Sep 13, 2026
@vitejs/plugin-react 6.1.0 -> 6.1.1, @types/react-dom 19.2.4 -> 19.2.7 and @playwright/test 1.62.1 -> 1.63.0 (Dependabot #25, #26, #27). All three touch `package-lock.json`, so merging them one at a time forces a rebase of the rest; taken together here as one upgrade instead, which is one CI run rather than three plus the churn. Plotly (#23) is deliberately not in this commit. Verifying them surfaced a pre-existing defect worth more than the bumps. `npm run test:static` failed fourteen of nineteen tests, and not because of the upgrade: `playwright.config.ts` rebuilds `dist/` with `npm run build` and **no** `VITE_STATIC_API`, so running the stubbed suite before the static one silently leaves an API-mode bundle for the static suite to test. It requests `/api/...`, `vite preview` has nothing to proxy to, and every page renders empty. The five tests that still passed were the mobile-layout ones, which check only that nothing scrolls sideways -- true of a blank page. That is the "two suites test different things" trap with a sharper edge: the order you run them in changes whether the second one means anything. `tests-static/assert-static-build.ts` now refuses to start and says which artifact is present and how to rebuild it. The guard's first version looked for `"/api` with a double quote and never matched -- the template literal survives minification backtick-quoted -- so it passed on exactly the artifact it exists to reject. Verified in both directions: it fires on an API-mode build and stays quiet on a static one. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
MarlenMM
added a commit
that referenced
this pull request
Sep 13, 2026
Dependabot #23 wanted `plotly.js-dist-min` 3.7.0 -> 4.0.0. Looking at why that package was here at all: nothing imports it, and `react-plotly.js` has no dependencies -- only a peer on `plotly.js`, which npm had been installing separately all along. Removing `plotly.js-dist-min` left the largest built chunk **byte-identical at 4,652,805 bytes**, which is the check that settles it rather than reading imports. So it is gone, and `plotly.js` is now an explicit dependency instead of an auto-installed peer -- it is what `Chart.tsx` already imports its types from, and leaning on npm's peer auto-install for the runtime library of every chart in the app is a dependency that exists by accident. With that resolved the real question was the major bump, and this is the library whose last two upgrades blanked every chart while TypeScript, the build and CI stayed green. Taken on its own, verified the way that history demands: plotly.js 4.1.0, chunk 4.65 MB -> 4.11 MB stock page 3 figures, all with SVG and drawn traces dashboard 1 figure, the indicator gauge drawn screener 0 figures (matches the source: no <Chart>) track record 0 figures (an inline-SVG whisker, not plotly) console no messages at all, zero failed resources window.Plotly 4.1.0 All four trace types the app uses are covered by those pages -- candlestick, scatter, scatterpolar and indicator -- and the polar sublayer stack renders, so the radar is genuinely drawing rather than mounting empty. The maplibre override still resolves to 6.9.0 under plotly 4, so `npm audit` stays clean; the note about it is folded into the backlog row. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
Author
|
Looks like plotly.js-dist-min is no longer a dependency, so this is no longer needed. |
dependabot
Bot
deleted the
dependabot/npm_and_yarn/frontend/plotly.js-dist-min-4.0.0
branch
September 13, 2026 03:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps plotly.js-dist-min from 3.7.0 to 4.0.0.
Release notes
Sourced from plotly.js-dist-min's releases.
... (truncated)
Changelog
Sourced from plotly.js-dist-min's changelog.
... (truncated)
Commits
e020cc04.0.0b9e8135Updates for release v4.0.0b7516d7Merge pull request #7988 from plotly/cam/add-regl-aliasd7ea88dbuild: Add alias for regl in esbuild config8bc6ee5Merge pull request #7984 from plotly/v4.001a6cc4Merge pull request #7945 from plotly/update-quiver-api58f2a0bMerge remote-tracking branch 'origin/master' into v4.0c061695Merge pull request #7815 from keilogic/fix-scrollzoom-automargin-jitter614cb6fadd draftlog74a7200cleanupDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)