Fix antenna height value sometimes showing floating point noise - #4664
Open
Withalion wants to merge 1 commit into
Open
Fix antenna height value sometimes showing floating point noise#4664Withalion wants to merge 1 commit into
Withalion wants to merge 1 commit into
Conversation
Collaborator
Author
|
@IvaKuklica could you please test it, I couldn't reliably replicate this issue even on previous builds |
Coverage Report for CI Build 32822897205Warning No base build found for commit Coverage: 59.08%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats
💛 - Coveralls |
📦 Build Artifacts Ready
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The antenna height setting in Settings sometimes didn't round the value to 3 decimal places and instead showed floating points noise as well (e.g.
1.45000000000000002). Apparently QML was completely okay with use supplying double to string :). Added another guard (InputUtils::formatNumber()) to fix it.