Feature/ch 287 - #861
Open
aranega wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes CH-287
Implemented solution
The solution relies on the addition of an extra entry in the
value-template.yamlfile which allows the user to declare a mapping to change the base image. The mapping affects the build args which are passed to skaffold to build the images, effectively replacing the base image with the one declared in thevalue-template.yamlfile. The PR also document about the path to override for apps wich do not rely on an accessibleDockerfile(e.g: argo, or the gatekeeper)Note: Some tests realted to secure secret are failing on
developthe same pre-existing failing tests are still failing with this PR.How to test this PR
To test the PR, the
value-template.yamlfile can be updated with a specific mapping for the source image, e.g:and the new deployment configuration generated using
harness-deployment.After the generation, the
skaffold.yamlfile can be opened to see thatbuildArgshave been impacted formyappand that the new base imagemybaseimg:123have been properly referenced.Sanity checks:
Breaking changes (select one):
breaking-changeand the migration procedure is well described abovePossible deployment updates issues (select one):
alert:deploymentTest coverage (select one):
Documentation (select one):
Nice to have (if relevant):