ci: lint PR titles as conventional commits - #11
Merged
Conversation
foundation was the only fleet repo without the Title Lint gate seed, stem and niac all require, so nothing enforced the conventional-commit format that release tooling and the commit convention depend on. Ports the sibling workflow verbatim except for its lint-issue-title job, which labels offending issues `status: needs-info`. foundation carries only the default GitHub label set, so that job would fail on the label write rather than on the title it is meant to check. PR *body* lint is deliberately not ported — see the PR discussion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the parity gap noted in #9: foundation was the only fleet repo without the
Lint PR Titlegate that seed, stem and niac all require, so nothing enforced the conventional-commit title format the commit convention and release tooling depend on.Ports the sibling
title-lint.ymlverbatim, with one deliberate omission.Why the
lint-issue-titlejob is left outseed's version of this workflow has a second job that validates issue titles and, on failure, adds a
status: needs-infolabel. foundation carries only the nine default GitHub labels — nostatus: needs-info— so that job would fail on the label write rather than on the title it is meant to check. Porting it would need the fleet's label taxonomy created here first, which is a separate decision.Why PR body lint is NOT ported
I checked before porting it, and it would have deadlocked the repo. seed/stem/niac's
pr-body-lint.ymlrequires four headings and a linked issue:foundation has 1 issue total, and none of the three PRs merged today (#7, #9, #10) reference one — all three would have been blocked by a required check. The sibling repos have active issue trackers; this one does not, so the same workflow means something very different here.
That is a workflow-policy call, not a mechanical port, so it is your decision rather than mine:
CI Completeis the gate; body discipline stays a convention.Next step (needs admin, not in this PR)
Once merged,
Lint PR Titlebecomes requirable. I'll add it alongsideCI Completein branch protection.Verification
This PR's own title exercises the gate.