Add check for pre-release generated content#2373
Conversation
|
|
This check can silently miss pre-release content:
Could we support both current header formats and add focused tests for each, plus the unrecognized-header case? |
|
@mdboom I looked more closely, I believe these are the only essential changes in scope for this PR:
The second format is used by six files: driver, runtime, and nvrtc, each as .pyx and .pxd. (This is also exactly Andy’s first point, and what I shared earlier offline.)
If it's not easy to add CTK metadata to those files, it would seem OK to explicitly exempt them, but to reject every other sealed file with zero, multiple, or unrecognized version headers. That accommodates the status quo while also ensuring that future generator-format drift fails loudly. — I believe this is also exactly Andy's second point. |
Now that our generator behaves differently, this is an extra check for pre-release content.